-
Notifications
You must be signed in to change notification settings - Fork 519
Use ServiceTrafficDistribution to make Services topology-aware when runtime Kubernetes >= 1.31 #11178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ServiceTrafficDistribution to make Services topology-aware when runtime Kubernetes >= 1.31 #11178
Conversation
Skipping CI for Draft Pull Request. |
6b5c72f
to
9885f4a
Compare
Yes, I have to rebase, I know, and it is my list for this week. Otherwise, it can be reviewed, of course. |
bb1007f
to
4564223
Compare
4564223
to
f764674
Compare
f764674
to
be209b2
Compare
I finally managed to rebase the PR. Sorry for the long delay. |
/retest-required |
/assign |
…untime Kubernetes version >= 1.31 Co-authored-by: Maximilian Geberl <maximilian.geberl@stackit.cloud>
be209b2
to
027a023
Compare
I did a no-op rebase to be able to debug the failing e2e test in reproducible manner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the adjustments 🙂
Apart from the feedback in the comments, could you enhance the GRM documentation here and explain that ServiceTrafficDistribution
is usually used for clusters running Kubernetes 1.31 and higher (maybe refer to docs/operations/topology_aware_routing.md
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/lgtm
/approve
LGTM label has been added. Git tree hash: 6b696a2c3c4c3c95f0f639a85c810a5d1a62236e
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timuthy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-gardener-integration |
How to categorize this PR?
/area networking
/area high-availability
/kind enhancement
What this PR does / why we need it:
This PR is based on @dergeberl's work in #10973. The topic was worked on during Gardener Hackathon 2024/2.
Which issue(s) this PR fixes:
Part of #10421
Special notes for your reviewer:
N/A
Release note: